uranusjr commented on code in PR #73015:
URL: https://github.com/apache/airflow/pull/73015#discussion_r4491091448
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -62,11 +76,20 @@ def __init__(
bundle_name=self.name,
version=self.version,
bucket_name=self.bucket_name,
- prefix=self.prefix,
aws_conn_id=self.aws_conn_id,
+ **self._log_fields(),
Review Comment:
Subclasses could easily get this wrong. Instead of a separate function
returning a dict (which the shape cannot be type-checked), it would be better
to have each subclass override a `_get_logger` function instead to return a
full logger. The base class could provide a function to generate common
functions for each subclass to forward to the logger constructor instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
