aoelvp94 commented on code in PR #73015:
URL: https://github.com/apache/airflow/pull/73015#discussion_r4522076560
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -163,7 +143,221 @@ def view_url_template(self) -> str | None:
if self.s3_hook.region_name:
url += f".{self.s3_hook.region_name}"
url += ".amazonaws.com"
- if self.prefix:
- url += f"/{self.prefix}"
+ key = self._view_url_key()
+ if key:
+ url += f"/{key}"
return url
+
+ def _reject_version_refresh(self) -> None:
+ if self.version:
+ raise AirflowException("Refreshing a specific version is not
supported")
+
+ def refresh(self) -> None:
+ """Refresh the Dag bundle by updating the local Dag files from S3."""
+ self._reject_version_refresh()
+ with self.lock():
+ self._refresh_locked()
+
+ def _refresh_locked(self) -> None:
+ """Stage the bundle while the bundle lock is held."""
+ raise NotImplementedError
Review Comment:
Done, `_refresh_locked` is now an `@abstractmethod` (same style as
`BaseDagBundle.refresh`).
https://github.com/aoelvp94/airflow/commit/74bdc13f8359f61d546e0b1345f43d7f707af00e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
