turbaszek commented on a change in pull request #8534: URL: https://github.com/apache/airflow/pull/8534#discussion_r415314647
########## File path: airflow/providers/amazon/aws/hooks/base_aws.py ########## @@ -62,16 +63,14 @@ class AwsBaseHook(BaseHook): def __init__( self, - aws_conn_id="aws_default", + aws_conn_id: Optional[str] = "aws_default", Review comment: > This does not cause error for AWS. AWS hooks should support falling back to using default credential chain lookup behavior when connection id is not specified. That's why I used "probably" because I don't know AWS hook behavior. Still we should use this: ``` aws_conn_id: str = "aws_default" ``` or this: ``` aws_conn_id: Optional[str] = None ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org