mik-laj commented on a change in pull request #8534:
URL: https://github.com/apache/airflow/pull/8534#discussion_r415325115



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -62,16 +63,14 @@ class AwsBaseHook(BaseHook):
 
     def __init__(
             self,
-            aws_conn_id="aws_default",
+            aws_conn_id: Optional[str] = "aws_default",

Review comment:
       Authorization using the metaserver is particularly problematic, because 
the server may have wider rights than we expect the instance user to have. 
Example: The server may have read / write access to Stackdriver logs, but the 
user should not have these privileges. The similar thing is with system buckets 
that the server can use, but the user should not be able to modify them. A 
similar thing looks like system buckets that the server can use, but the user 
should not be able to modify them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to