turbaszek commented on a change in pull request #8534:
URL: https://github.com/apache/airflow/pull/8534#discussion_r415427532
##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -62,16 +63,14 @@ class AwsBaseHook(BaseHook):
def __init__(
self,
- aws_conn_id="aws_default",
+ aws_conn_id: Optional[str] = "aws_default",
Review comment:
> the wording in the documentation linked by @zhongjiajie is a little
bit misleading, which probably caused confusion between `Optional` type and
optional argument.
I can quite agree. In fact, I think introducing types in dynamically typed
langauge creates more confusion that in statically typed one. In most places in
airflow, I think we are using `Optional` when the default value is `None`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
