Jzjsnow opened a new pull request, #3423:
URL: https://github.com/apache/amoro/pull/3423
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in
https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title,
e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related
issue
-->
The time-related configuration items in the current ams configuration are
inconsistent in type, with both `Long` and `Duration` types. This results in
users having to convert to milliseconds when using these `Long` types, which is
not user friendly.
In addition, storage-related parameters such as
thrift-server.max-message-size only support Long type (default unit is byte).
It would be more user-friendly to support user-specified units, as in the
[Apache Flink
configuration](https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/deployment/config/#duration).
Close #3418.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Adjust the data type of all time-related configuration items to `Duration`.
- Support for setting memory units for storage related items.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
