Jzjsnow commented on code in PR #3423:
URL: https://github.com/apache/amoro/pull/3423#discussion_r1942645813
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -226,11 +226,12 @@ public class AmoroManagementConf {
.defaultValue(1261)
.withDescription("Port that the optimizing service thrift server is
bound to.");
- public static final ConfigOption<Long> THRIFT_MAX_MESSAGE_SIZE =
+ public static final ConfigOption<String> THRIFT_MAX_MESSAGE_SIZE =
Review Comment:
Thanks for the suggestion, previously conversion to `MemorySize` type was
not supported in `ConfigHelpers`. In my latest commit, `ConfigOption` can now
take the `MemorySize` generic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
