klion26 commented on code in PR #3423: URL: https://github.com/apache/amoro/pull/3423#discussion_r1942409198
########## amoro-ams/src/test/java/org/apache/amoro/server/TestAmoroManagementConf.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.server; + +import static org.apache.amoro.server.AmoroServiceContainer.expandConfigMap; + +import org.apache.amoro.config.ConfigOption; +import org.apache.amoro.config.Configurations; +import org.apache.amoro.shade.guava32.com.google.common.collect.ImmutableMap; +import org.apache.amoro.shade.guava32.com.google.common.collect.Maps; +import org.apache.amoro.shade.guava32.com.google.common.io.Resources; +import org.apache.amoro.shade.jackson2.com.fasterxml.jackson.core.type.TypeReference; +import org.apache.amoro.shade.jackson2.com.fasterxml.jackson.databind.JsonNode; +import org.apache.amoro.utils.JacksonUtil; +import org.apache.amoro.utils.MemorySize; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.yaml.snakeyaml.Yaml; + +import java.io.IOException; +import java.net.URISyntaxException; +import java.net.URL; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.time.Duration; +import java.util.Map; + +public class TestAmoroManagementConf { + private static final ConfigOption<Duration>[] TIME_RELATED_CONFIG_OPTIONS = Review Comment: Do we need to add a test to cover the migration for the changed configs? so that we know this does not change the user behavior, or if the behavior is indeed needed, we need to add them to the release note so that the user can know it(maybe add a upgrade script is better) ########## amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java: ########## @@ -226,11 +226,12 @@ public class AmoroManagementConf { .defaultValue(1261) .withDescription("Port that the optimizing service thrift server is bound to."); - public static final ConfigOption<Long> THRIFT_MAX_MESSAGE_SIZE = + public static final ConfigOption<String> THRIFT_MAX_MESSAGE_SIZE = Review Comment: will it be better to set this to `MemorySize`? ########## amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java: ########## @@ -342,16 +343,16 @@ public class AmoroManagementConf { .defaultValue(1000L) .withDescription("Max wait time before getting a connection timeout."); - public static final ConfigOption<Long> OPTIMIZER_HB_TIMEOUT = + public static final ConfigOption<Duration> OPTIMIZER_HB_TIMEOUT = ConfigOptions.key("optimizer.heart-beat-timeout") - .longType() - .defaultValue(60000L) + .durationType() + .defaultValue(Duration.ofMinutes(1)) .withDescription("Timeout duration for Optimizer heartbeat."); - public static final ConfigOption<Long> OPTIMIZER_TASK_ACK_TIMEOUT = + public static final ConfigOption<Duration> OPTIMIZER_TASK_ACK_TIMEOUT = ConfigOptions.key("optimizer.task-ack-timeout") - .longType() - .defaultValue(30000L) + .durationType() + .defaultValue(Duration.ofSeconds(30)) Review Comment: If a user sets this conf to `60000` before this commit, and he/she needs to adjust the config to `60`, am I understanding right? if it is true, can we still use millisecond as the unit in the current commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
