weimingdiit commented on code in PR #2131:
URL: https://github.com/apache/auron/pull/2131#discussion_r3026628647


##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -941,6 +940,9 @@ object NativeConverters extends Logging {
       case DayOfMonth(child) => buildExtScalarFunction("Spark_Day", child :: 
Nil, IntegerType)
       case DayOfWeek(child) =>
         buildExtScalarFunction("Spark_DayOfWeek", child :: Nil, IntegerType)
+      case WeekOfYear(child) =>
+        buildExtScalarFunction("Spark_WeekOfYear", child :: Nil, IntegerType)

Review Comment:
   Thanks for your comment.  yes, that was missing. I updated 
NativeConverters.scala so WeekOfYear now goes through the timezone-aware helper 
path, which passes the session time zone for TimestampType inputs instead of 
calling Spark_WeekOfYear with only the child expression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to