ShreyeshArangath commented on code in PR #2131:
URL: https://github.com/apache/auron/pull/2131#discussion_r3029081389
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -941,6 +940,9 @@ object NativeConverters extends Logging {
case DayOfMonth(child) => buildExtScalarFunction("Spark_Day", child ::
Nil, IntegerType)
Review Comment:
DayOfMonth and DayofWeek should also have time zone passed to them as well,
I can fix that as part of https://github.com/apache/auron/pull/2156, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
