weimingdiit commented on code in PR #2131:
URL: https://github.com/apache/auron/pull/2131#discussion_r3031105184
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -941,6 +940,9 @@ object NativeConverters extends Logging {
case DayOfMonth(child) => buildExtScalarFunction("Spark_Day", child ::
Nil, IntegerType)
Review Comment:
Good catch, thanks! Fixing DayOfMonth and DayOfWeek as part of #2156 sounds
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
