[
https://issues.apache.org/jira/browse/BEAM-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265065#comment-16265065
]
ASF GitHub Bot commented on BEAM-3008:
--------------------------------------
GitHub user dmytroivanov4206 opened a pull request:
https://github.com/apache/beam/pull/4171
[BEAM-3008] Extends API for BigtableIO Read and Write by adding
withInstanceId and withProjectId
Adds withInstanceId and withProjectId to the BigtableIO Read and Write
classes, first out of four steps to fix [BEAM-3008] bug.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmytroivanov4206/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4171
----
commit 28637766921200f03313088bfc0271453c0e3ae7
Author: Dmytro Ivanov <dimon.i...@gmail.com>
Date: 2017-11-24T09:18:14Z
Adds withInstanceId and withProjectId to the BigtableIO Read and Write
classes, first out of four steps to fix [BEAM-3008] bug.
----
> BigtableIO should use ValueProviders
> -------------------------------------
>
> Key: BEAM-3008
> URL: https://issues.apache.org/jira/browse/BEAM-3008
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-gcp
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
>
> [https://github.com/apache/beam/pull/2057] is an effort towards BigtableIO
> templatization. This Issue is a request to get a fully featured template for
> BigtableIO.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
