[
https://issues.apache.org/jira/browse/BEAM-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265314#comment-16265314
]
ASF GitHub Bot commented on BEAM-3008:
--------------------------------------
sduskis commented on a change in pull request #4171: [BEAM-3008] Extends API
for BigtableIO Read and Write by adding withInstanceId and withProjectId
URL: https://github.com/apache/beam/pull/4171#discussion_r152978149
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -78,38 +78,38 @@
* <p>The Bigtable source returns a set of rows from a single table, returning
a
* {@code PCollection<Row>}.
*
- * <p>To configure a Cloud Bigtable source, you must supply a table id and a
{@link BigtableOptions}
- * or builder configured with the project and other information necessary to
identify the
- * Bigtable instance. By default, {@link BigtableIO.Read} will read all rows
in the table. The row
- * range to be read can optionally be restricted using {@link
BigtableIO.Read#withKeyRange}, and
- * a {@link RowFilter} can be specified using {@link
BigtableIO.Read#withRowFilter}. For example:
+ * <p>To configure a Cloud Bigtable source, you must supply a table id, a
project id, an instance
+ * id and optionally a {@link BigtableOptions} to provide more specific
connection configuration.
+ * By default, {@link BigtableIO.Read} will read all rows in the table. The
row range to be read
+ * can optionally be restricted using {@link BigtableIO.Read#withKeyRange},
and a {@link RowFilter}
+ * can be specified using {@link BigtableIO.Read#withRowFilter}. For example:
*
* <pre>{@code
- * BigtableOptions.Builder optionsBuilder =
- * new BigtableOptions.Builder()
- * .setProjectId("project")
- * .setInstanceId("instance");
*
* Pipeline p = ...;
*
* // Scan the entire table.
* p.apply("read",
* BigtableIO.read()
* .withBigtableOptions(optionsBuilder)
Review comment:
Can you please remove `.withBigtableOptions(optionsBuilder)` for this
example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> BigtableIO should use ValueProviders
> -------------------------------------
>
> Key: BEAM-3008
> URL: https://issues.apache.org/jira/browse/BEAM-3008
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-gcp
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
>
> [https://github.com/apache/beam/pull/2057] is an effort towards BigtableIO
> templatization. This Issue is a request to get a fully featured template for
> BigtableIO.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
