[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=97181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-97181
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/18 18:47
Start Date: 01/May/18 18:47
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5254:
[BEAM-4044] [SQL] Simplify TableProvider interface
URL: https://github.com/apache/beam/pull/5254#discussion_r185300879
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProvider.java
##########
@@ -41,7 +39,7 @@
* LOCATION '[PROJECT_ID]:[DATASET].[TABLE]'
* }</pre>
*/
-public class BigQueryTableProvider implements TableProvider {
+public class BigQueryTableProvider extends InMemoryTableProvider {
Review comment:
It is going to be in-memory in the sense that the metadata is in-memory
only. I'm happy to change the name to something less confusing. Do you have any
suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 97181)
Time Spent: 9.5h (was: 9h 20m)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
