[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=97992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-97992
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/18 18:16
Start Date: 03/May/18 18:16
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #5224:
[BEAM-4044] [SQL] Add tables via TableStore in Schema, execute DDL in Calcite
model
URL: https://github.com/apache/beam/pull/5224#discussion_r185880448
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlDropObject.java
##########
@@ -51,8 +59,39 @@
name.unparse(writer, leftPrec, rightPrec);
}
- public String getNameSimple() {
- return name.getSimple().toLowerCase();
+ public void execute(CalcitePrepare.Context context) {
+ final List<String> path = context.getDefaultSchemaPath();
+ CalciteSchema schema = context.getRootSchema();
+ for (String p : path) {
+ schema = schema.getSubSchema(p, true);
+ }
+ final boolean existed;
+ switch (getKind()) {
+ case DROP_TABLE:
+ case DROP_MATERIALIZED_VIEW:
Review comment:
Do we support views? If we don't have concrete plans to support them i'd
rather remove all related code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 97992)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
