[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=97999&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-97999
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/18 18:16
Start Date: 03/May/18 18:16
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #5224:
[BEAM-4044] [SQL] Add tables via TableStore in Schema, execute DDL in Calcite
model
URL: https://github.com/apache/beam/pull/5224#discussion_r185882943
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -133,9 +133,10 @@ public Join copy(
.setCoder(CalciteUtils.toBeamSchema(getRowType()).getRowCoder());
}
- PCollection<Row> leftRows = inputPCollections.apply("left",
leftRelNode.toPTransform());
+ PCollection<Row> leftRows =
+ inputPCollections.getPipeline().apply("left",
leftRelNode.toPTransform());
PCollection<Row> rightRows =
- inputPCollections.apply("right", rightRelNode.toPTransform());
+ inputPCollections.getPipeline().apply("right",
rightRelNode.toPTransform());
Review comment:
Not sure if it's the right thing to access the pipeline directly. Who knows
what's there? Does it have a source so that it can produce elements? With
PCollections I would have at least an expectation that there should be elements
in it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 97999)
Time Spent: 11h 20m (was: 11h 10m)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
