[
https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=144082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144082
]
ASF GitHub Bot logged work on BEAM-5337:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/18 21:17
Start Date: 13/Sep/18 21:17
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6385:
[BEAM-5337] Fix flaky test UnboundedSourceWrapperTest#testValueEmission
URL: https://github.com/apache/beam/pull/6385#discussion_r217537490
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java
##########
@@ -187,10 +188,9 @@ public void collect(
@Override
public void close() {}
});
- } catch (SuccessException e) {
+ } finally {
processingTimeUpdateThread.interrupt();
Review comment:
In a low probability case when the thread was not sleeping at the time of
interrupt, the interrupted exception will not be thrown.
Instead of interrupting shall we use an atomic boolean etc to terminate the
while loop?
Alternatively we can also check on Thread.currentThread().isInterrupted() .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144082)
Time Spent: 1h (was: 50m)
> [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake]
> Build times out in beam-runners-flink target
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-5337
> URL: https://issues.apache.org/jira/browse/BEAM-5337
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, test-failures
> Reporter: Mikhail Gryzykhin
> Assignee: Maximilian Michels
> Priority: Critical
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Job times out.
> Failing job url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/consoleFull]
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/consoleFull]
> https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/consoleFull
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
