[
https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=144280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144280
]
ASF GitHub Bot logged work on BEAM-5337:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/18 13:16
Start Date: 14/Sep/18 13:16
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6385:
[BEAM-5337] Fix flaky test UnboundedSourceWrapperTest#testValueEmission
URL: https://github.com/apache/beam/pull/6385#discussion_r217708477
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java
##########
@@ -134,11 +133,13 @@ public void testValueEmission() throws Exception {
public void run() {
while (true) {
try {
- synchronized (testHarness.getCheckpointLock()) {
-
testHarness.setProcessingTime(System.currentTimeMillis());
- }
+ testHarness.setProcessingTime(System.currentTimeMillis());
Thread.sleep(1000);
+ } catch (InterruptedException e) {
+ // this is ok
+ break;
} catch (Exception e) {
+ e.printStackTrace();
Review comment:
I don't consider output to stderr or stdout "logging". That's what we have
slf4j and log levels for. Granted it is only test code, but we should remain
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144280)
Time Spent: 1h 50m (was: 1h 40m)
> [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake]
> Build times out in beam-runners-flink target
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-5337
> URL: https://issues.apache.org/jira/browse/BEAM-5337
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, test-failures
> Reporter: Mikhail Gryzykhin
> Assignee: Maximilian Michels
> Priority: Critical
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Job times out.
> Failing job url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/consoleFull]
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/consoleFull]
> https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/consoleFull
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
