[ https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=144207&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144207 ]
ASF GitHub Bot logged work on BEAM-5337: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Sep/18 07:43 Start Date: 14/Sep/18 07:43 Worklog Time Spent: 10m Work Description: asfgit closed pull request #6385: [BEAM-5337] Fix flaky test UnboundedSourceWrapperTest#testValueEmission URL: https://github.com/apache/beam/pull/6385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java index 74db90a7d07..94110b26beb 100644 --- a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java +++ b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java @@ -88,10 +88,9 @@ public ParameterizedUnboundedSourceWrapperTest(int numTasks, int numSplits) { * Creates a {@link UnboundedSourceWrapper} that has one or multiple readers per source. If * numSplits > numTasks the source has one source will manage multiple readers. */ - @Test + @Test(timeout = 30_000) public void testValueEmission() throws Exception { final int numElementsPerShard = 20; - final Object checkpointLock = new Object(); PipelineOptions options = PipelineOptionsFactory.create(); final long[] numElementsReceived = {0L}; @@ -134,11 +133,13 @@ public void testValueEmission() throws Exception { public void run() { while (true) { try { - synchronized (testHarness.getCheckpointLock()) { - testHarness.setProcessingTime(System.currentTimeMillis()); - } + testHarness.setProcessingTime(System.currentTimeMillis()); Thread.sleep(1000); + } catch (InterruptedException e) { + // this is ok + break; } catch (Exception e) { + e.printStackTrace(); break; } } @@ -151,7 +152,7 @@ public void run() { try { testHarness.open(); sourceOperator.run( - checkpointLock, + testHarness.getCheckpointLock(), new TestStreamStatusMaintainer(), new Output<StreamRecord<WindowedValue<ValueWithRecordId<KV<Integer, Integer>>>>>() { private boolean hasSeenMaxWatermark = false; @@ -187,10 +188,9 @@ public void collect( @Override public void close() {} }); - } catch (SuccessException e) { + } finally { processingTimeUpdateThread.interrupt(); processingTimeUpdateThread.join(); - // success, continue for the other subtask indices } } // verify that we get the expected count across all subtasks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 144207) Time Spent: 1h 40m (was: 1.5h) > [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] > Build times out in beam-runners-flink target > --------------------------------------------------------------------------------------------------------------------- > > Key: BEAM-5337 > URL: https://issues.apache.org/jira/browse/BEAM-5337 > Project: Beam > Issue Type: Bug > Components: runner-flink, test-failures > Reporter: Mikhail Gryzykhin > Assignee: Maximilian Michels > Priority: Critical > Time Spent: 1h 40m > Remaining Estimate: 0h > > Job times out. > Failing job url: > [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/consoleFull] > [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/consoleFull] > https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/consoleFull > -- This message was sent by Atlassian JIRA (v7.6.3#76005)