horizonzy commented on code in PR #4044:
URL: https://github.com/apache/bookkeeper/pull/4044#discussion_r1286822472
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageTest.java:
##########
@@ -170,4 +170,41 @@ public void simple() throws Exception {
db.close();
FileUtils.deleteDirectory(tmpDir);
}
+
+ @Test
+ public void testBatch() throws Exception {
+
+ configuration.setOperationMaxNumbersInSingleRocksDBWriteBatch(5);
+
+ File tmpDir =
Files.createTempDirectory("junitTemporaryFolder").toFile();
+ Files.createDirectory(Paths.get(tmpDir.toString(), "subDir"));
+
+ KeyValueStorage db =
storageFactory.newKeyValueStorage(tmpDir.toString(), "subDir",
DbConfigType.Default,
+ configuration);
+
+ assertEquals(null, db.getFloor(toArray(3)));
+ assertEquals(0, db.count());
+
+ Batch batch = db.newBatch();
+ assertEquals(0, batch.batchCount());
+
+ batch.put(toArray(1), toArray(1));
+ batch.put(toArray(2), toArray(2));
+ assertEquals(2, batch.batchCount());
+
+ batch.put(toArray(3), toArray(3));
+ batch.put(toArray(4), toArray(4));
+ batch.put(toArray(5), toArray(5));
+ assertEquals(0, batch.batchCount());
+ batch.put(toArray(6), toArray(6));
+ assertEquals(1, batch.batchCount());
+
+ batch.flush();
Review Comment:
Here trigger flush() directly, the `batchCount `should be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
