hangc0276 commented on code in PR #4044:
URL: https://github.com/apache/bookkeeper/pull/4044#discussion_r1287334352
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java:
##########
@@ -540,6 +551,7 @@ public void put(byte[] key, byte[] value) throws
IOException {
public void remove(byte[] key) throws IOException {
try {
writeBatch.delete(key);
+ countBatchAndFlushIfNeeded();
Review Comment:
When we try to remove a key from the writeBatch, but the writeBatch has been
triggered flushed in `put` method, will it impact the correctness of the key
value stored in the RocksDB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
