horizonzy commented on code in PR #4044:
URL: https://github.com/apache/bookkeeper/pull/4044#discussion_r1286890640


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java:
##########
@@ -548,17 +560,31 @@ public void remove(byte[] key) throws IOException {
         @Override
         public void clear() {
             writeBatch.clear();
+            batchCount = 0;

Review Comment:
   If manual flush is completed and the batchCount reaches the batchSize again, 
does it mean that the operations in this batch will be applied to the database 
twice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to