danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279590981
########## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ########## @@ -230,6 +237,15 @@ public boolean isSemiJoinDone() { return false; } + /** + * Returns whether this Join is a semijoin. + * + * @return true if this is semi but without correlate variables. + */ + public boolean isSemiJoin() { Review comment: Cause the semiJoin decision happens everywhere, it is so special cause it only outputs one side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services