danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279226492
########## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ########## @@ -230,6 +237,17 @@ public boolean isSemiJoinDone() { return false; } + /** + * Returns whether this LogicalJoin is a semi-join but does + * not comes from decorrelate. + * + * @return true if this is semi but without correlate variables. + */ + public boolean isNonCorrelateSemiJoin() { + return (this.variablesSet == null || this.variablesSet.size() == 0) + && joinType == JoinRelType.SEMI; + } Review comment: @hsyuan Removing variables set from Correlate is another huge change, if we really decide to do it, i'm suggesting to put it in another patch. And i'm glad to take it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services