hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285229897
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -43,6 +91,14 @@ public boolean generatesNullsOnLeft() {
return (this == RIGHT) || (this == FULL);
}
+ /**
+ * Returns whether a join of this type may generate NULL values, either on
the
+ * left-hand side or right-hand side.
+ */
+ public boolean generatesNulls() {
Review comment:
Can we just name it to `isOuterJoin`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
