hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285290481
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java
##########
@@ -186,7 +189,8 @@ protected RelMdExpressionLineage() {}
// Extract input fields referenced by expression
final ImmutableBitSet inputFieldsUsed = extractInputRefs(outputExpression);
- if (rel.getJoinType() != JoinRelType.INNER) {
+ if (rel.getJoinType().generatesNullsOnLeft()
+ || rel.getJoinType().generatesNullsOnRight()) {
Review comment:
Can we use `isOuterJoin` to do the check? Or just remove this check, add
`FULL` check in `else` in L209.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
