danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285324183
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java
##########
@@ -186,7 +189,8 @@ protected RelMdExpressionLineage() {}
// Extract input fields referenced by expression
final ImmutableBitSet inputFieldsUsed = extractInputRefs(outputExpression);
- if (rel.getJoinType() != JoinRelType.INNER) {
+ if (rel.getJoinType().generatesNullsOnLeft()
+ || rel.getJoinType().generatesNullsOnRight()) {
Review comment:
We can use `isOuterJoin` to do the check, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
