danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324373
########## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java ########## @@ -258,11 +262,17 @@ protected RelMdExpressionLineage() {} } // Right input references might need to be updated if there are // table names clashes with left input + final RelDataType fullRowType = SqlValidatorUtil.createJoinType( + rexBuilder.getTypeFactory(), + rel.getLeft().getRowType(), + rel.getRight().getRowType(), + null, + ImmutableList.of()); Review comment: Because `SEMI`(and `ANTI`) row type does not contains fields from right input, use a full row type here will allow us to inferrer lineage for expressions that reference the right fields. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services