xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584839764 > I would rather add a method to RelDataType that computes the digest without taking column names to the consideration. That would work. Then mapDigestToRel key would be Pair<String, String> where the second string is the new digest without column name. It won't solve the memory growth problem though. > here we build strings again and again, and it might help if we would be able to skip building strings. Not sure what you mean. RelNode caches digest until recomputeDigest() is called. We don't build strings over and over. There might be a better abstraction to represent digest, but I think string serves the purpose currently. It would be a big change to use something else, and I don't see clear benefits.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
