xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584911960 >Every time we create a new RelType we build stings. Every time we create RelNode we build strings. Every time we create RexNode we build strings. Yes, but if not string, you would be creating something else. I am fine with the initial overhead. But we cannot afford recomputing hash code every time when access the map. Unfortunately this is what List<RelDataType> does with your change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
