[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

[GitBox]

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from 
Project#digest
URL: https://github.com/apache/calcite/pull/1740#issuecomment-584848797
 
 
   > second string is the new digest
   
   The use of stings for digests is unfortunate. It takes time to build a 
string, however in practice we don't need that as a single object.
   
   What I mean is something behind the lines of
   
   ```java
   class RelDataType {
      Digest digest;
      Digest getDigestsSansFieldNames() {
          Digest digest = this.digset;    
          if (digest != null) return digest;
          this.digest = digest = ...;
          return digest;
      }
   }
   
   class Digest {
      final int hashCode;
      final Object[] contents;
   }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services