danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913741092
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node, scope).validate(targetRowType);
}
+ protected void validateTableFunction(SqlCall node, SqlValidatorScope scope,
+ RelDataType targetRowType) {
+ // Dig out real call; TABLE() wrapper is just syntactic.
+ SqlCall call = node.operand(0);
+ if (call.getOperator() instanceof SqlTableFunction) {
+ SqlTableFunction tableFunction = (SqlTableFunction) call.getOperator();
+ boolean visitedRowSemanticsTable = false;
+ for (int idx = 0; idx < call.operandCount(); idx++) {
+ TableCharacteristic tableCharacteristic =
tableFunction.tableCharacteristic(idx);
+ if (tableCharacteristic != null) {
+ // Skip validate if current input table has set semantics
+ if (tableCharacteristic.semantics ==
TableCharacteristic.Semantics.SET) {
+ continue;
+ }
+ // A table function at most has one input table with row semantics
+ if (visitedRowSemanticsTable) {
+ throw newValidationError(
+ call,
+
RESOURCE.multipleRowSemanticsTables(call.getOperator().getName()));
+ }
+ visitedRowSemanticsTable = true;
+ }
+ // If table function defines the parameter is not table parameter, or
is an input table
+ // parameter with row semantics, then it should not be with PARTITION
BY OR ORDER BY.
+ SqlNode currentNode = call.operand(idx);
+ if (currentNode instanceof SqlCall) {
+ final SqlOperator op = ((SqlCall) currentNode).getOperator();
+ if (op == SqlStdOperatorTable.SET_SEMANTICS_TABLE) {
+ throwInvalidRowSemanticsTable(call, idx, (SqlCall) currentNode);
+ } else if (op == SqlStdOperatorTable.ARGUMENT_ASSIGNMENT) {
+ // Dig out the underlying operand
+ SqlNode realNode = ((SqlBasicCall) currentNode).operand(0);
+ if (realNode instanceof SqlCall) {
Review Comment:
Can move the digging in the first so that the validation logic only need on.
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node, scope).validate(targetRowType);
}
+ protected void validateTableFunction(SqlCall node, SqlValidatorScope scope,
+ RelDataType targetRowType) {
+ // Dig out real call; TABLE() wrapper is just syntactic.
+ SqlCall call = node.operand(0);
+ if (call.getOperator() instanceof SqlTableFunction) {
+ SqlTableFunction tableFunction = (SqlTableFunction) call.getOperator();
+ boolean visitedRowSemanticsTable = false;
+ for (int idx = 0; idx < call.operandCount(); idx++) {
+ TableCharacteristic tableCharacteristic =
tableFunction.tableCharacteristic(idx);
+ if (tableCharacteristic != null) {
+ // Skip validate if current input table has set semantics
+ if (tableCharacteristic.semantics ==
TableCharacteristic.Semantics.SET) {
+ continue;
+ }
+ // A table function at most has one input table with row semantics
+ if (visitedRowSemanticsTable) {
+ throw newValidationError(
+ call,
+
RESOURCE.multipleRowSemanticsTables(call.getOperator().getName()));
+ }
+ visitedRowSemanticsTable = true;
+ }
+ // If table function defines the parameter is not table parameter, or
is an input table
+ // parameter with row semantics, then it should not be with PARTITION
BY OR ORDER BY.
+ SqlNode currentNode = call.operand(idx);
+ if (currentNode instanceof SqlCall) {
+ final SqlOperator op = ((SqlCall) currentNode).getOperator();
+ if (op == SqlStdOperatorTable.SET_SEMANTICS_TABLE) {
+ throwInvalidRowSemanticsTable(call, idx, (SqlCall) currentNode);
+ } else if (op == SqlStdOperatorTable.ARGUMENT_ASSIGNMENT) {
+ // Dig out the underlying operand
+ SqlNode realNode = ((SqlBasicCall) currentNode).operand(0);
+ if (realNode instanceof SqlCall) {
Review Comment:
Can move the digging in the first so that the validation logic only need one
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
