danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913751422
########## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ########## @@ -4164,6 +4164,77 @@ void checkPeriodPredicate(Checker checker) { sql(sql).ok(expected); } + @Test void testTableFunction() { + final String sql = "select * from table(score(table orders))"; + final String expected = "SELECT *\n" + + "FROM TABLE(`SCORE`((TABLE `ORDERS`)))"; + sql(sql).ok(expected); + } + + @Test void testTableFunctionWithPartitionKey() { + // test one partition key for input table + final String sql = "select * from table(topn(table orders partition by productid, 3))"; + final String expected = "SELECT *\n" + + "FROM TABLE(`TOPN`(((TABLE `ORDERS`) PARTITION BY `PRODUCTID`), 3))"; + sql(sql).ok(expected); + } + + @Test void testTableFunctionWithMultiplePartitionKeys() { + // test multiple partition keys for input table + final String sql = + "select * from table(topn(table orders partition by (orderId, productid), 3))"; + final String expected = "SELECT *\n" + + "FROM TABLE(`TOPN`(((TABLE `ORDERS`) PARTITION BY `ORDERID`, `PRODUCTID`), 3))"; + sql(sql).ok(expected); + } Review Comment: We need some tests for multiple partition/ordering keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org