beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r915658421
##########
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##########
@@ -958,7 +960,17 @@ private static List<Integer> elseArgs(int count) {
private static List<RexNode> convertOperands(SqlRexContext cx,
SqlCall call, SqlOperandTypeChecker.Consistency consistency) {
- return convertOperands(cx, call, call.getOperandList(), consistency);
+ List<SqlNode> operandList;
+ if (call.getOperator() instanceof SqlTableFunction) {
+ // skip set semantic table node of table function
Review Comment:
> I see too many instance of for SqlTableFunction, can it has its own SqlKind
I think table function has its own SqlKind is a good idea.
However, it is not a compatible change between versions because the SqlKind
of existed table functions defined in each implementation instead of a unified
SqlKind.
##########
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##########
@@ -958,7 +960,17 @@ private static List<Integer> elseArgs(int count) {
private static List<RexNode> convertOperands(SqlRexContext cx,
SqlCall call, SqlOperandTypeChecker.Consistency consistency) {
- return convertOperands(cx, call, call.getOperandList(), consistency);
+ List<SqlNode> operandList;
+ if (call.getOperator() instanceof SqlTableFunction) {
+ // skip set semantic table node of table function
Review Comment:
> I see too many instance of for SqlTableFunction, can it has its own SqlKind
I think table function has its own SqlKind is a good idea.
However, it is not a compatible change between versions because the SqlKind
of existed table functions defined in each implementation instead of a unified
SqlKind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
