stoty commented on code in PR #239:
URL: https://github.com/apache/calcite-avatica/pull/239#discussion_r1502212296
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -186,6 +187,14 @@ private static void setupUsers(File keytabDir) throws
KrbException {
assertEquals(401, conn.getResponseCode());
}
+ @Test public void testServerVersionNotReturnedForUnauthorisedAccess() throws
Exception {
Review Comment:
While technically any ot the Authentication tests are fine, this is not
related to Kerberos in any way.
I think we should either
- add this to every authenitcation test
- add this to the BASIC test
Even though we know that setting is independent of the authentication used
(it's not even AAA specific)
TDD principles would dictate the we add this to every authentication test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
