vaijosh commented on code in PR #239:
URL: https://github.com/apache/calcite-avatica/pull/239#discussion_r1502252243


##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -186,6 +187,14 @@ private static void setupUsers(File keytabDir) throws 
KrbException {
     assertEquals(401, conn.getResponseCode());
   }
 
+  @Test public void testServerVersionNotReturnedForUnauthorisedAccess() throws 
Exception {

Review Comment:
   @stoty 
   It will be overhead if we add to every authentication test or even base 
test. Every time the logic will be executed.
   So, I am wondering if a separate class (which I had proposed earlier) can 
solve this issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to