stoty commented on code in PR #239:
URL: https://github.com/apache/calcite-avatica/pull/239#discussion_r1502267908
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -186,6 +187,14 @@ private static void setupUsers(File keytabDir) throws
KrbException {
assertEquals(401, conn.getResponseCode());
}
+ @Test public void testServerVersionNotReturnedForUnauthorisedAccess() throws
Exception {
Review Comment:
My gut feeling is that the overhead a single HTTP call is minial.
Setting up and starting the Avatica server jetty etc is the expensive
operation.
We'd have to add the new method to a huge number of test classes to make
starting a new environment worthwile.
You may want to log the start and stop milliseconds in the test to see if
the runtime of the new time is signifcant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
