chucheng92 commented on code in PR #3355:
URL: https://github.com/apache/calcite/pull/3355#discussion_r1508430436
##########
core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java:
##########
@@ -31,11 +32,41 @@
* Parameter type-checking strategy where types must be Array and Array
element type.
*/
public class ArrayElementOperandTypeChecker implements SqlOperandTypeChecker {
+ //~ Instance fields --------------------------------------------------------
+
+ private final boolean allowNullCheck;
+ private final boolean allowCast;
Review Comment:
Here, by adding member variables, these two parameters can be passed in
through different constructors. For functions that do not require null
checking, use the default constructor. For scenarios that require null checking
or allow cast, it will be more versatile to pass them in through different
constructors. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
