chucheng92 commented on code in PR #3355:
URL: https://github.com/apache/calcite/pull/3355#discussion_r1509890311
##########
core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java:
##########
@@ -31,11 +32,41 @@
* Parameter type-checking strategy where types must be Array and Array
element type.
*/
public class ArrayElementOperandTypeChecker implements SqlOperandTypeChecker {
+ //~ Instance fields --------------------------------------------------------
+
+ private final boolean allowNullCheck;
+ private final boolean allowCast;
Review Comment:
There is currently no case used, but since it is a public operand checker
class, it may be used in other ways in the future. I would be ok if we set it
directly to false.
thanks for patient reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
