mihaibudiu commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1509387190
########## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ########## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must be Array and Array element type. */ public class ArrayElementOperandTypeChecker implements SqlOperandTypeChecker { + //~ Instance fields -------------------------------------------------------- + + private final boolean allowNullCheck; + private final boolean allowCast; Review Comment: I understand why, but I am pointing out that all uses of this class now have allowCast = false. Do you foresee a use case where allowCast = true? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org