JiajunBernoulli commented on code in PR #3712: URL: https://github.com/apache/calcite/pull/3712#discussion_r1510199048
########## babel/src/test/resources/sql/spark.iq: ########## @@ -0,0 +1,243 @@ +# spark.iq - Babel test for Spark dialect of SQL Review Comment: I am not against using this test. But I want to know the necessity of using QuidemTest for Spark. Because your code may become a future contribution specification. Let's discuss two questions. 1. Why need `spark.iq`? 2. What features need to be tested and what features don't need to be tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
