YiwenWu commented on code in PR #3712: URL: https://github.com/apache/calcite/pull/3712#discussion_r1510212954
########## babel/src/test/resources/sql/spark.iq: ########## @@ -0,0 +1,243 @@ +# spark.iq - Babel test for Spark dialect of SQL Review Comment: 1. Compared to `SqlOperatorTest`, I think the function tests in Babel are more accurate and complete. Therefore, references`big-query.iq` and `redshift.iq`, `spark.iq` were added to verify the correctness of function execution. 2. I think that unit tests can be added to this file when adding spark functions, but it is unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
