caicancai commented on code in PR #3712: URL: https://github.com/apache/calcite/pull/3712#discussion_r1510203765
########## babel/src/test/resources/sql/spark.iq: ########## @@ -0,0 +1,243 @@ +# spark.iq - Babel test for Spark dialect of SQL Review Comment: +1 At present, calcite has adapted many spark functions. Do we need to add all spark functions? What are the benefits after adding them? ########## babel/src/test/resources/sql/spark.iq: ########## @@ -0,0 +1,243 @@ +# spark.iq - Babel test for Spark dialect of SQL Review Comment: +1 At present, calcite has adapted many spark functions. Do we need to add all spark functions? What are the benefits after adding them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
