dssysolyatin commented on code in PR #3177:
URL: https://github.com/apache/calcite/pull/3177#discussion_r1818885601
##########
core/src/main/java/org/apache/calcite/sql/SqlBasicFunction.java:
##########
@@ -42,7 +42,7 @@
* behavior only by providing strategy objects, not by overriding methods in a
* subclass.
*/
-public class SqlBasicFunction extends SqlFunction {
+public final class SqlBasicFunction extends SqlFunction {
Review Comment:
Ok, I remembered why I added it. If you look at the comment in the class:
```
The class is final, and instances are immutable
Since the class is final, you can modify behavior only by providing strategy
objects, not by overriding methods in a subclass.
```
This comment was added when the class was introduced, and from the Git
history, I can see that making it final was simply overlooked.
Think it is right to make it final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
