dssysolyatin commented on code in PR #3177:
URL: https://github.com/apache/calcite/pull/3177#discussion_r1819790270
##########
core/src/main/java/org/apache/calcite/sql/SqlBasicFunction.java:
##########
@@ -42,7 +42,7 @@
* behavior only by providing strategy objects, not by overriding methods in a
* subclass.
*/
-public class SqlBasicFunction extends SqlFunction {
+public final class SqlBasicFunction extends SqlFunction {
Review Comment:
@mihaibudiu This class can’t be inherited from outside because it has only
private constructor, which prevents other classes from calling super(). Making
it non-final only allows subclasses within SqlBasicFunction itself.
Perhaps this was done to allow adding an inner Builder class in the future,
but I’m not sure.
Let’s ask the author of the SqlBasicFunction, @julianhyde, about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
