dssysolyatin commented on PR #3177: URL: https://github.com/apache/calcite/pull/3177#issuecomment-2443963234
@mihaibudiu Let's keep this change. 1. As mentioned before, the constructor is private, which means that subclasses cannot be created outside of SqlBasicFunction. 2. Due to point 1, adding `final` will not break binary compatibility either ([Java Language Specification, Section 13.4.2](https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.2)). 3. If someone decides to introduce a Builder inside SqlBasicFunction in the future, removing `final` also will not break binary compatibility ([Java Language Specification, Section 13.4.2](https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.2)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
