mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819493389
##########
core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java:
##########
@@ -283,7 +283,7 @@ private static SqlMonikerImpl moniker(CalciteSchema schema,
@Nullable String nam
* or classes.
*
* @see ModelHandler#addFunctions */
- public static SqlOperatorTable operatorTable(String... classNames) {
+ public SqlOperatorTable operatorTable(String... classNames) {
Review Comment:
See my comment below about public methods; you cannot change public method
signature without changing the major version of the project. That is called
"semantic versioning" https://semver.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
