xiedeyantu commented on code in PR #5050:
URL: https://github.com/apache/calcite/pull/5050#discussion_r3505642076
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##########
@@ -101,36 +101,50 @@ public static EnumerableLimit create(final RelNode input,
@Nullable RexNode offs
result.format);
Expression v = builder.append("child", result.block);
+ Expression roundingPolicyExp = getRoundingPolicy(implementor);
Review Comment:
I don't think we need such a complex strategy; we can control the rounding
method using expressions instead. We simply need to select a standard approach
and document it with a comment. I suspect @mihaibudiu would also prefer a
simpler implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
