tkalkirill commented on code in PR #5050:
URL: https://github.com/apache/calcite/pull/5050#discussion_r3527090091
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##########
@@ -101,36 +101,50 @@ public static EnumerableLimit create(final RelNode input,
@Nullable RexNode offs
result.format);
Expression v = builder.append("child", result.block);
+ Expression roundingPolicyExp = getRoundingPolicy(implementor);
Review Comment:
@xiedeyantu
I’ve taken care of the second point as we discussed in ticket.
I haven't seen any objections to `FetchOffsetRoundingPolicy`, so I’d leave
it as is for now.
For my project, I’ll need rounding to an integer as in Oracle, but for the
original implementation, let's stick to the PostgreSQL approach, given how
frequently it’s used as a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
