xiedeyantu commented on code in PR #5050:
URL: https://github.com/apache/calcite/pull/5050#discussion_r3511266856
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##########
@@ -101,36 +101,50 @@ public static EnumerableLimit create(final RelNode input,
@Nullable RexNode offs
result.format);
Expression v = builder.append("child", result.block);
+ Expression roundingPolicyExp = getRoundingPolicy(implementor);
Review Comment:
What I really meant was that if we could support expressions in `limit` and
`offset`, we could do a lot of things, even support partial rounding logic,
thus eliminating the need for additional configuration options. As for specific
implementation details, I haven't considered that in detail yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
